Ensure screen saver blocker removed when window closed #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
commented
May 16, 2023
| @@ -42,6 +42,10 @@ const VHS_BANDWIDTH_VARIANCE = videojs.Vhs.BANDWIDTH_VARIANCE | |||
|
|
|||
| export default defineComponent({ | |||
| name: 'FtVideoPlayer', | |||
| beforeRouteLeave: function (_to, _from, next) { | |||
| window.removeEventListener('beforeunload', this.stopPowerSaveBlocker) | |||
There was a problem hiding this comment.
I am not sure if this can/should be moved into beforeDestroy
But this is how it's done currently in Watch view
There was a problem hiding this comment.
This has to be moved to beforeDestroy, the route hooks only get triggered in components that are directly inside the router view. So for us those are the components in the src/renderer/views. Additionally the player gets destroyed and a new instance created when you change formats (maybe we can change that in the future, but for the moment that makes it easier for us), so you want this removed as soon as it's destroyed, so that you get rid of the event handler for all instances of the player.
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 16, 2023
absidue
approved these changes
May 17, 2023
|
@ChunkyProgrammer need more approval chunks |
efb4f5ff-1298-471a-8973-3d47447115dc
requested review from
ChunkyProgrammer
and removed request for
ChunkyProgrammer
ChunkyProgrammer
approved these changes
May 23, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Similar to #1217
Might work for reload case in #3286 too
Description
beforeDestroydoesn't work for window closenklayman/vue-cli-plugin-electron-builder#389
Screenshots
Lazy! (Well or a video with at least 1 min is needed, definitely too big to be uploaded)
Testing
Desktop
Additional context