Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cursor moving while navigating search suggestions #3566

Merged
merged 1 commit into from
May 21, 2023

Conversation

absidue
Copy link
Member

@absidue absidue commented May 19, 2023

Fix cursor moving while navigating search suggestions

Pull Request Type

  • Bugfix

Related issue

closes #3561

Description

Currently navigating through the search suggestions in the search bar moves the cursor around in the search bar. As you may want to keep typing, the cursor moving around unnecessarily is undesired.

Testing

  1. Enter some text into the search bar
  2. Use the up and down arrow keys to navigate through the search suggestions
  3. Check that the cursor is still where you left it

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 5445800

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label May 19, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) May 19, 2023 20:28
@FreeTubeBot FreeTubeBot merged commit 3e543ae into FreeTubeApp:development May 21, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label May 21, 2023
@absidue absidue deleted the cursor-suggestions branch May 21, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Going up and down in the search suggestions moves cursor
5 participants