Update watch page chapter component to scroll to current chapter on expand #3610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
absidue
reviewed
May 30, 2023
| // Must wait until rendering done after value change | ||
| nextTick(() => { | ||
| if (container != null && currentChaptersItem != null) { | ||
| // Watch view can be ready sooner than this component |
There was a problem hiding this comment.
This comment seems like a copy paste issue, as it doesn't seem relevant here (presumably this came from the playlist component).
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
May 30, 2023
ChunkyProgrammer
approved these changes
May 30, 2023
|
@absidue ~ |
absidue
approved these changes
Jun 2, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Similar to #3399
Description
Very annoying to have to scroll & find current chapter after watching video for several chapters and then expand the chapter panel
This PR makes expanding also scroll to current chapter in the chapter panel
Screenshots
Before:
After:
Testing
Desktop
Additional context