comment url & custom emoji on invidious API #3658
Conversation
github-actions
bot
added
the
PR: waiting for review
There was a problem hiding this comment.
LGTM, thank you @lamemakes for your contribution. I'll hope we will see more of your contributions in the future!
Edit: inserted testing video in PR body
2nd Edit: Removed closes from the PR body because this doesn't solve the original reported issue. I noticed this when writing the issue and decided to put it in the issue as something to note.
|
@efb4f5ff-1298-471a-8973-3d47447115dc You certainly will - I'm super appreciative for all the work you guys do to maintain this wonderful application! |
|
Hiii Thank you again for opening this pull request ^^. Screenshot of the issue: |
Head branch was pushed to by a user without write access
|
Gahhh great catch. The replace vs replaceAll always gets me. Looks to be functional now, updated the body of the PR with screenshots from that video. |
github-actions
bot
removed
the
PR: waiting for review
Comment URL & custom emoji on invidious API
Pull Request Type
Related issue
#3642
Description
This PR mainly fixes the issue of custom emojis not showing up when using the invidious API, but also slightly touches the upstream issue of improper YouTube links in channels. An Invidious PR was just put up to fully mediate this issue though.
Screenshots
Comment before fix (note messed up channel URL and no custom emoji):
Comment after FreeTube fix, but without upstream fixes (current state, note emoji fix):
Comment with both FreeTube and upstream fix:
Comment with multiple custom emojis
Testing
This was tested by confirming the comment now looks as inspected utilizing both a remote invidious instance and a locally "fixed" instance of invidious which shows proper channel URL/linking.
Video to test with: https://youtu.be/LHRw3sDQH1w
Pinned comment has multiple custom emojis: https://youtu.be/v3wm83zoSSY
Desktop