Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed incorrect invidious comment linking #3711

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

lamemakes
Copy link
Contributor

Fixed incorrect invidious comment linking

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Closes #3669

Description

A small PR to fix the linking within comments. Previously, the stripping of anchor tags was confusing the auto-linker due to indivious' truncation of the url (adding the "..."). This new change keeps the anchor tags in place, and feeds them to the auto-linker.

Testing

This was tested to confirm previous bugged comments were functional, mainly using https://youtu.be/4OjoZZVyHgc

Desktop

  • OS: Fedora
  • OS Version: 37
  • FreeTube version: 87a389c

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 27, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) June 27, 2023 16:50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @lamemakes !

@FreeTubeBot FreeTubeBot merged commit d989af2 into FreeTubeApp:development Jun 28, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: IV URL in comment section redirect to wrong page
5 participants