Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Current Invidious Instance input field removes character while typing #3776

Merged
merged 1 commit into from
Jul 17, 2023
Merged

Fix Current Invidious Instance input field removes character while typing #3776

merged 1 commit into from
Jul 17, 2023

Conversation

PikachuEXE
Copy link
Collaborator

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

Fixes #3303

Description

make sure it's not "http(s)://" when we remove a trailing slash

#3303 (comment)

Screenshots

Lazy

Testing

See #3303

Desktop

  • OS:
  • OS Version:
  • FreeTube version:

Additional context

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 14, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) July 14, 2023 07:05
@absidue
Copy link
Member

absidue commented Jul 14, 2023

I think the bigger issue is that when we store what the user has typed it, it triggers the watcher on the currentInvidiousInstance computed property that then results in the value in the field getting updated.
We should probably only set the value on the field when the component is mounted/created instead of letting it get updated live while the user is typing.

@PikachuEXE
Copy link
Collaborator Author

I have no idea what you are talking about. Please take over the PR if you want to :P

efb4f5ff-1298-471a-8973-3d47447115dc
efb4f5ff-1298-471a-8973-3d47447115dc approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit 37e67f5 into FreeTubeApp:development Jul 17, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@absidue absidue absidue approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Current Invidious Instance input field removes character while typing
5 participants
@PikachuEXE @absidue @efb4f5ff-1298-471a-8973-3d47447115dc @ChunkyProgrammer @FreeTubeBot