Fix playlists for external players with no index support #3797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
auto-merge was automatically disabled
July 21, 2023 13:00
Head branch was pushed to by a user without write access
4 tasks
PikachuEXE
approved these changes
Jul 22, 2023
ChunkyProgrammer
approved these changes
Jul 25, 2023
absidue
approved these changes
Jul 28, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix playlists for external players with playlist but no index support
Pull Request Type
Related issue
Description
The current logic doesn't consider external players that have support for playlists but not playlist indexes enabled, leading to entire playlists being sent to the external player when a single video is opened from within a playlist.
This adds an additional check to only send the video URL for these players when a playlist with an index is specified, for all other players or if no index is specified the playlist URL will be sent.
Screenshots
Testing
Desktop
Additional context