Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantic roles to make the site more accessible #3887

Conversation

ChunkyProgrammer
Copy link
Member

Add semantic roles to make the site more accessible

Pull Request Type

  • Bugfix

Related issue

#1525
#693

Description

This PR :

  • adds h3s to search results
  • adds semantic roles to elements (nav, main)
  • properly sets the locale of the webpage

Testing

FreeTube should look and behave the same besides some headings being larger now
image

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.18.0

Co-Authored-By: Jason <84899178+jasonhenriquez@users.noreply.github.com>
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 15, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 15, 2023 19:09
src/renderer/components/ft-input/ft-input.vue Outdated Show resolved Hide resolved
src/renderer/App.vue Outdated Show resolved Hide resolved
src/renderer/App.js Outdated Show resolved Hide resolved
src/renderer/scss-partials/_ft-list-item.scss Outdated Show resolved Hide resolved
src/renderer/App.js Outdated Show resolved Hide resolved
Co-Authored-By: absidue <48293849+absidue@users.noreply.github.com>
@ChunkyProgrammer ChunkyProgrammer force-pushed the add-semantic-roles-to-make-site-more-accessible branch from 05fb04a to d9b986b Compare August 15, 2023 19:38
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FreeTubeBot FreeTubeBot merged commit eff4a0a into FreeTubeApp:development Aug 16, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 16, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 21, 2023
* development:
  Translated using Weblate (Greek)
  Fix locales getting unnecessarily reprocessed for incremental builds (FreeTubeApp#3893)
  Fix the layout of the hashtag page (FreeTubeApp#3886)
  Translated using Weblate (French)
  Translated using Weblate (Swedish)
  Translated using Weblate (Indonesian)
  Translated using Weblate (Italian)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Italian)
  Translated using Weblate (Portuguese)
  Cleanup some template conditionals (FreeTubeApp#3888)
  Add semantic roles to make the site more accessible (FreeTubeApp#3887)
  Translated using Weblate (Japanese)
  Fix Update Subscription Details function when channel name is null (FreeTubeApp#3884)
  Translated using Weblate (Spanish)
  Translated using Weblate (Romanian)
  Translated using Weblate (Hebrew)
  local API: Add support for PageHeader channel header (FreeTubeApp#3871)
  Translated using Weblate (Chinese (Traditional))

# Conflicts:
#	src/renderer/components/ft-list-playlist/ft-list-playlist.vue
#	src/renderer/components/ft-list-video/ft-list-video.vue
#	src/renderer/views/UserPlaylists/UserPlaylists.vue
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Aug 21, 2023
* feature/playlist-2023-05:
  Translated using Weblate (Greek)
  Fix locales getting unnecessarily reprocessed for incremental builds (FreeTubeApp#3893)
  Fix the layout of the hashtag page (FreeTubeApp#3886)
  Translated using Weblate (French)
  Translated using Weblate (Swedish)
  Translated using Weblate (Indonesian)
  Translated using Weblate (Italian)
  Translated using Weblate (Portuguese (Brazil))
  Translated using Weblate (Italian)
  Translated using Weblate (Portuguese)
  Cleanup some template conditionals (FreeTubeApp#3888)
  Add semantic roles to make the site more accessible (FreeTubeApp#3887)
  Translated using Weblate (Japanese)
  Fix Update Subscription Details function when channel name is null (FreeTubeApp#3884)
  Translated using Weblate (Spanish)
  Translated using Weblate (Romanian)
  Translated using Weblate (Hebrew)
  local API: Add support for PageHeader channel header (FreeTubeApp#3871)
  ! Fix invalid prop type warning
  Translated using Weblate (Chinese (Traditional))
@ChunkyProgrammer ChunkyProgrammer deleted the add-semantic-roles-to-make-site-more-accessible branch September 12, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants