Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subscriptions: Add community tab #3973

Merged
merged 18 commits into from
Sep 23, 2023
Merged

Subscriptions: Add community tab #3973

merged 18 commits into from
Sep 23, 2023

Conversation

ChunkyProgrammer
Copy link
Member

Subscriptions: Add community tab

Pull Request Type

  • Feature Implementation

Related issue

closes #3593

Description

If you have less than 125 subscriptions in your profile then a tab is added on the subscription page for community posts.

Screenshots

image

Testing

(Local + Invidious)

  • view subscription page (less than 125 subscriptions)

  • see community tab

  • click on community tab

  • see posts ordered by date

  • disable community tab is Distraction Free Settings

  • view subscription page

  • dont see community tab

  • have over 125 subscriptions

  • view subscription page

  • dont see community tab

Desktop

  • OS: windows
  • OS Version: 10
  • FreeTube version: 0.19.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) August 29, 2023 16:14
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 29, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 30, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Aug 30, 2023
@PikachuEXE
Copy link
Collaborator

IV API = useless error messages
image

@PikachuEXE
Copy link
Collaborator

PikachuEXE commented Aug 30, 2023 •
edited
Loading

Changed this.activeSubscriptionList.length < 125 to 5 so I don't have to subscribe that many channels
But tab still visible

disable community tab in Distraction Free Settings works though
image

@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Aug 31, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 1, 2023

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 1, 2023
PikachuEXE
PikachuEXE previously approved these changes Sep 2, 2023
View reviewed changes
@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 18, 2023
@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 20, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 20, 2023
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

PikachuEXE
PikachuEXE previously approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming nothing much change since last reviewed

absidue
absidue previously approved these changes Sep 21, 2023
View reviewed changes
@github-actions github-actions bot added PR: merge conflicts / rebase needed and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 22, 2023
@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ChunkyProgrammer ChunkyProgrammer dismissed stale reviews from absidue and PikachuEXE via cd916e2 September 22, 2023 15:34
@github-actions
Copy link
Contributor

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ChunkyProgrammer ChunkyProgrammer added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 22, 2023
@FreeTubeBot FreeTubeBot merged commit 47ef3e5 into FreeTubeApp:development Sep 23, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 23, 2023
@PikachuEXE PikachuEXE mentioned this pull request Sep 23, 2023
Merged
4 tasks
@ChunkyProgrammer ChunkyProgrammer deleted the add-subscription-community branch September 23, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc Awaiting requested review from efb4f5ff-1298-471a-8973-3d47447115dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Access all subscribed youtuber's posts from a community viewer button
6 participants
@ChunkyProgrammer @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @absidue @kommunarr @FreeTubeBot