Default theatre mode no sidebar #3981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… "hidden" (FreeTubeApp#3931)" This reverts commit 621cc27.
… mode is enabled by default
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
|
Not working - "Hide Recommended Videos" OFF / "Enable Theatre Mode by Default" ON Screen.Recording.2023-09-01.at.11.55.27.mov |
|
@PikachuEXE Try using a video without a playlist, that looks like an issue with the save playlist in history setting, which is probably unrelated to this change, unless it happens for lots of history entries (see error popup and empty playlists view on your video). |
|
I tried it, just too lazy to record a new one :P Screen.Recording.2023-09-01.at.14.50.45.mov |
|
Looks like it's working to me, at least that's how theatre mode has always looked on my device. |
|
It's the loading icon still on the left... |
|
@PikachuEXE should be fixed now |
PikachuEXE
approved these changes
Sep 5, 2023
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 6, 2023
ChunkyProgrammer
approved these changes
Sep 7, 2023
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default theatre mode no sidebar
Pull Request Type
Related issue
closes #3923
#3931 (original pull request)
Description
This pull request aims to fix the same issue as the original pull request did, but does so without enforcing a 3 colum layout on the loading icon (see screenshot).
Screenshots
Testing
Loading icon:
Original test cases:
Check that the layout looks correct and that enabling theatre mode by default still works when it should.
Desktop