Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscribe button being clipped on Channel page (mobile/tablet view) #4057

Merged
merged 1 commit into from
Sep 19, 2023
Merged

Fix subscribe button being clipped on Channel page (mobile/tablet view) #4057

merged 1 commit into from
Sep 19, 2023

Conversation

kommunarr
Copy link
Collaborator

Fix subscribe button being clipped on Channel page (mobile/tablet view)

Pull Request Type

  • Bugfix

Related issue

None

Description

Fixes mobile and tablet view of subscribe button.

Screenshots

Before:
Screenshot_20230918_180308

After:
Screenshot_20230918_180355

Testing

  1. Open channel page
  2. Set viewport width to ~<734px, when the subscribe button wraps over to the left side. Ensure button is full-height.

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.0

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 18, 2023 23:07
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 18, 2023
PikachuEXE
PikachuEXE approved these changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's <640px for me
image

@FreeTubeBot FreeTubeBot merged commit a271d45 into FreeTubeApp:development Sep 19, 2023
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 19, 2023
@kommunarr kommunarr mentioned this pull request Sep 21, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kommunarr @PikachuEXE @absidue @ChunkyProgrammer @FreeTubeBot