Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrap channel tabs as soon as there isn't enough screen space #4139

Merged

Conversation

MarmadileManteater
Copy link
Contributor

Wrap channel tabs as soon as there isn't enough screen space

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Description

Currently, at certain breakpoints, the channel page is pushed down one full screen length. This is because the channel tabs are not wrapping until 800px. This PR aims to address this issue by making the channel tabs flex-wrap by default.

Screenshots

before after
before-1 after-1

Testing

  1. Open a channel with a lot of channel tabs (ex: https://www.youtube.com/channel/UChRV-sCl5Fma4qm_hFpDKBQ)
  2. Reduce the page width
  3. Ensure the page doesn't suddenly shift down 1 entire screen length

Desktop

  • OS: Windows 10
  • OS Version: Pro Version 21H2 Installed on ‎4/‎3/‎2022 OS build 19044.1889 Experience Windows Feature Experience Pack 120.2212.4180.0
  • FreeTube version: 3c0ed26

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 12, 2023
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 12, 2023 16:38
Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spotted before but forgot to fix it
Thanks!!

@FreeTubeBot FreeTubeBot merged commit 1a92d4b into FreeTubeApp:development Oct 14, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 14, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Oct 17, 2023
* development:
  Bump webpack from 5.88.2 to 5.89.0 (FreeTubeApp#4168)
  Fix playlists not showing up on artist topic channels with the local API (FreeTubeApp#4129)
  Bump undici from 5.19.1 to 5.26.3 (FreeTubeApp#4173)
  Bump marked from 9.1.0 to 9.1.2 (FreeTubeApp#4171)
  Bump sass from 1.69.0 to 1.69.3 (FreeTubeApp#4169)
  Bump the eslint group with 2 updates (FreeTubeApp#4166)
  Bump the babel group with 2 updates (FreeTubeApp#4165)
  Truncate title of playlist in queue window (FreeTubeApp#4134)
  Wrap channel tabs as soon as there isn't enough screen space (FreeTubeApp#4139)
  Keep download folder path when changing to 'ask for download path' and back (FreeTubeApp#4101)
  Add external player support for Baka, Celluloid & Haruna (FreeTubeApp#4067)
  Fix error when clicking on the current quality in the DASH quality selector (FreeTubeApp#4130)
@absidue absidue mentioned this pull request Oct 22, 2023
6 tasks
@MarmadileManteater MarmadileManteater deleted the fix-channel-page-cls branch March 16, 2024 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants