-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open/close all settings tabs persistent toggle #4204
Open/close all settings tabs persistent toggle #4204
Conversation
I wonder if it's possible to do that check inside the My suggested solution would be to add a prop to the ft-settings-section component so that you can still pass in a value from the theme settings one (have it optional with the default value being false), then in the |
758b00f
to
06c345b
Compare
Just updated now to something like that (but still uses |
06c345b
to
642ebf5
Compare
src/renderer/components/ft-settings-section/ft-settings-section.vue
Outdated
Show resolved
Hide resolved
I see examples of both expanded/collapsed & closed/open, for example in this MDN article:
Note the use of the language of tabs as well. Still, I changed it to your suggestions because I have no strong preference. |
Whenever you're ready to re-review, @PikachuEXE: changes have been made. |
I havent tested this yet but why does the user have to go into one of the setting to find this setting feels a bit weird to me. I would expect a toggle like this to be outside of all the settings that makes more sense in my mind |
I was thinking that at first, but then again, it's a persistent setting that affects appearance of stuff, which places it in here. How would that external toggle's placement look like? |
I was thinking of a toggle that is on top of and aligns right above the General settings That's was my initial thought when I read the issue not sure if that makes the most sense |
So it's no longer a setting? |
Oh, to be clear, I was still thinking of it as a persistent setting in that case. I just think there's less need to call attention to that fact if we change the placement, if that makes sense. |
Looks a bit weird to me, would aligning it to the left make it better? |
If you put the A-Z switch from #4231 next to it, it might look better, as then there are two switches using the space instead of just one. |
Looks better than placement in the middle but i would like the others to chime in also on this
In all my life i just cant remember seeing such a toggle within the menu instead of outside of all the menus but if that is totally a thing maybe it would make more sense to go with nr 2 |
One point in favor of @absidue's suggestion is that both of those controls change the verticality of where the Theme Settings are, so you have to scroll back to find them. Keeping them on the outside makes them very easy to toggle on/off. |
I think we should merge this one before #4231. Once this is merged, I'll move the settings sort in that PR to the top area as a toggle. As stated, much better user experience for those when the settings toggles are in one fixed space as opposed to having the manipulated section bouncing to a different height. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Open/close all settings tabs persistent toggle
Pull Request Type
Related issue
closes #1743
Description
Adds toggle in Theme Settings determining whether all settings tabs or opened or closed by default. The result is immediate, but the Theme Settings tab is kept open in both cases for convenience.
Screenshot
Testing
Desktop