-
Notifications
You must be signed in to change notification settings - Fork 887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show latest from channel #4352
Show latest from channel #4352
Conversation
As a user I have no idea what |
The label that's used in the code is Edit: modified the description, if that helps |
Which means |
|
|
I think the singular |
Not so clear for me but I guess you can ask other people :P |
What about "Only show latest video for each channel"? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am OK with "for each channel"
src/renderer/components/subscription-settings/subscription-settings.vue
Outdated
Show resolved
Hide resolved
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious about the order of the filtering, currently it's done before we filter out premieres or currently live live streams, so theoretically you could end up with nothing being shown for a channel (filter picks the first item which is an upcoming premiere, upcoming premiere filter filters it out).
Would it be better to do this filtering after the content type filters, that way there is a higher chance that you will actually see something for all channels? (Should be as simple as moving the new code in the subscriptions helper file down 30ish lines).
…henriquez/FreeTube into feat/only-show-latest-from-channel
1cdd070
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
Show latest from channel
Pull Request Type
Related issue
closes #546
Description
Shows only the most recent video from each unique channel that the user is subscribed to in the Subscriptions tab. Latest of each video tab that you're on, to be specific (Videos, Shorts, & Live, but not Community).
Screenshots
Testing
Test Videos, Shorts, and Live tabs.
Desktop
Additional context
I wonder if it would be a neat feature later on to have these subscription settings show up on the subscription page. Not sure how to feel about it, but share your thoughts on that with your review if you have any.