Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show latest from channel #4352

Conversation

kommunarr
Copy link
Collaborator

@kommunarr kommunarr commented Nov 18, 2023

Show latest from channel

Pull Request Type

  • Feature Implementation

Related issue

closes #546

Description

Shows only the most recent video from each unique channel that the user is subscribed to in the Subscriptions tab. Latest of each video tab that you're on, to be specific (Videos, Shorts, & Live, but not Community).

Screenshots

Screenshot_20231118_165810

Testing

Test Videos, Shorts, and Live tabs.

  • Test feature enabled with RSS feed enabled
  • Test feature enabled without RSS feed disabled
  • Test feature disabled

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.1

Additional context

I wonder if it would be a neat feature later on to have these subscription settings show up on the subscription page. Not sure how to feel about it, but share your thoughts on that with your review if you have any.

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) November 18, 2023 23:04
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 18, 2023
@PikachuEXE
Copy link
Collaborator

As a user I have no idea what latest video from each subscribed channel means

@kommunarr
Copy link
Collaborator Author

kommunarr commented Nov 19, 2023

As a user I have no idea what latest video from each subscribed channel means

The label that's used in the code is Only Show Latest Video from Channel. For reference, the label for this feature in Invidious is Only show latest video from channel. Are you saying the text is confusing or do you need context on the original feature request?

Edit: modified the description, if that helps

@PikachuEXE
Copy link
Collaborator

Which means Show Only The Latest Videos from Channels (well not sure how to express per channel well)
The label text should make user easier to understand that it's only one, latest, per channel
Coz when I read it first I read it as latest videos from channel (For me it's quite easy to be confused by Only Show Latest Video from Channel, missing only one & per channel)

@kommunarr
Copy link
Collaborator Author

Only show latest video from each subscribed channel?

@PikachuEXE
Copy link
Collaborator

the latest? Problem is that without the it reads similar to Latest News which seems multiple (per channel)

@kommunarr
Copy link
Collaborator Author

kommunarr commented Nov 19, 2023

I think the singular latest video instead of latest videos makes that clear enough, no? Presence of "the" doesn't change the meaning to me personally, as it can be used for either a singular or plural noun

@PikachuEXE
Copy link
Collaborator

Not so clear for me but I guess you can ask other people :P
Again I personally have no idea what it does on first read (well user can try and found out, but better if it's expressed well from the beginning)
If others feel like it's easy enough to be understood then I won't reject it just for the label text

@absidue
Copy link
Member

absidue commented Nov 21, 2023

What about "Only show latest video for each channel"?

Copy link
Collaborator

@PikachuEXE PikachuEXE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with "for each channel"

static/locales/en-US.yaml Outdated Show resolved Hide resolved
Co-authored-by: PikachuEXE <pikachuexe@gmail.com>
@kommunarr kommunarr requested a review from PikachuEXE November 22, 2023 18:10
PikachuEXE
PikachuEXE previously approved these changes Nov 22, 2023
Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm curious about the order of the filtering, currently it's done before we filter out premieres or currently live live streams, so theoretically you could end up with nothing being shown for a channel (filter picks the first item which is an upcoming premiere, upcoming premiere filter filters it out).

Would it be better to do this filtering after the content type filters, that way there is a higher chance that you will actually see something for all channels? (Should be as simple as moving the new code in the subscriptions helper file down 30ish lines).

Copy link
Member

@absidue absidue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:)

@FreeTubeBot FreeTubeBot merged commit 6af85b3 into FreeTubeApp:development Nov 26, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show only most recent video from a subscription
5 participants