Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor ft-subscribe-button visual bugfix #4451

Merged

Conversation

kommunarr
Copy link
Collaborator

Fix minor ft-subscribe-button visual bug

Pull Request Type

  • Bugfix

Related issue

N/A

Description

Fixes odd appearance of button on certain videos like this one (with locale set to English (US)): https://youtu.be/yOSdWqdyAuk

Does not affect any other instances of the ft-subscribe-button.

Screenshots

Before:
(Only one profile)
Screenshot_20231213_101044

(Multiple profiles)
Screenshot_20231213_101510

After:
(Only one profile)
Screenshot_20231213_101721

(Multiple profiles)
Screenshot_20231213_101614

Testing

Desktop

  • OS: OpenSUSE Tumbleweed
  • OS Version: 2023xxxx
  • FreeTube version: 0.19.1

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) December 13, 2023 16:20
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 13, 2023
@FreeTubeBot FreeTubeBot merged commit 3c3a83e into FreeTubeApp:development Dec 15, 2023
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Dec 15, 2023
PikachuEXE added a commit to PikachuEXE/FreeTube that referenced this pull request Dec 16, 2023
* development:
  Hide playlists in channel search results if "hide channel playlist" preference selected. (FreeTubeApp#4454)
  Fix issue with subscribe button styling in specific views (FreeTubeApp#4451)
  Translated using Weblate (Lithuanian)
  Bump electron from 27.1.3 to 28.0.0 (FreeTubeApp#4442)
  Fix pr-labeler.yml (FreeTubeApp#4449)
  Translated using Weblate (Estonian)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants