Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local API: Work around YouTube sending empty watch next responses #4626

Closed
wants to merge 1 commit into from

Conversation

absidue
Copy link
Member

@absidue absidue commented Jan 31, 2024

local API: Work around YouTube sending empty watch next responses

Pull Request Type

  • Bugfix

Related issue

closes #4625

Description

In draft status as this relies on LuanRT/YouTube.js#590.

YouTube has started randomly returning a watch next feed that only contains a continuation, this is similar to the empty response issue that we have on the community page (#3318, yes that pull request was 10 months ago, but the issue still exists on YouTube's side today), so the workaround is similar too.

This pull request will fetch the watch next continuation when the response is empty and there is a continuation (we can't do anything about videos that have an empty response and no continuation).

This only addresses the local API, as Invidious will need to add the workaround on their end too.

Screenshots

request-log

Testing

Test various videos and make sure that the watch next feed shows up, as the issue happens randomly you'll just have to try a few.
You'll know that the changes in this pull request came into action, when you see a second /next request right after the original /browse and /next requests (see screenshot above).

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: 0.19.1

@PikachuEXE
Copy link
Collaborator

@absidue https://github.com/LuanRT/YouTube.js/releases/tag/v9.0.2

@PikachuEXE
Copy link
Collaborator

Updated it local and it works

@FishZonez
Copy link

Updated it local and it works

Hey, I’m new to this. How can I update it too?

@absidue
Copy link
Member Author

absidue commented Feb 4, 2024

Closing as the problem seems to have been resolved on YouTube's end

@absidue absidue closed this Feb 4, 2024
@absidue absidue deleted the fix-watch-next branch February 4, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: No videos in up next/recommended
3 participants