Fixes opening an external player on the watch page passes user playlist #5263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes opening an external player on the watch page passes user playlist
Pull Request Type
Related issue
#5188 (it's a discussion so the close keyword doesn't work)
Description
The code to open an external player in the watch-video-info component was checking
this.inUserPlaylist
to decide whether or not to pass the playlist information to the external player. Unfortunately thoughthis.inUserPlaylist
didn't exist, so it was passing playlist information to the external player. This pull request adds the missinginUserPlaylist
property.Screenshots
Before:
After:
Testing
openInExternalPlayer
insrc/renderer/store/modules/utils.js
None
(you don't actually have to have the player installed, because of the code snippet above)Desktop