Update subscription cache when subscribing from the channel page

[absidue]

Update subscription cache when subscribing from the channel page

Pull Request Type

• Feature Implementation

Related issue

#5185 (review)

Inspired by: #4667

Description

When you visit a channel that you are already subscribed to, we update the subscription cache with the data we fetched to display on that channel. This pull request expands that to cover subscribing to a channel on the channel page too, as we already have the data we might as well add it to the cache. While this doesn't specifically help with the scenario in the video in this comment #5185 (review) (subscribing from the search results), it does solve it for the channel page.

As YouTube doesn't provide any published dates on the shorts tab, we unfortunately cannot cache the data from that tab, however we can still cache the videos, live and community tabs.

Testing

1. Turn off "Subscription Settings" -> "Fetch Feed Automatically"
2. Refresh your subscriptions
3. Subscribe to a channel that you are not subscribed to yet from the search page
4. Visit the subscriptions page
5. Notice that instead of showing the cached videos it says that you have turned off automatic fetching
6. Unsubscribe from that channel from any page that is not the channel page
7. Go back to the subscriptions page and notice that it shows the cached videos again
8. Visit the channel page of a channel you are not subscribed to yet
9. Subscribe to that channel from the channel page
10. Go back to the subscriptions page
11. It should be showing the previously cached videos as well as the videos from the channel you just subscribed to.

Desktop

• OS: Windows
• OS Version: 10
• FreeTube version: ddb495a

[PikachuEXE]

Works for sub, live, community post

[PikachuEXE]

[efb4f5ff-1298-471a-8973-3d47447115dc]

All tabs ok but shorts/live tab is showing that i have turned off automatic fetching

Edit: live only not showing up when channel you are subscribing to has a podcast tab and no live tab

2nd edit: this is happening for all tabs under the following condition. If channel you are subscribing to only has one tab e.g. only shorts tab. You will see the message in the subscription page on the videos/live/community tab

3rd edit: if channel has shorts the message still shows up but i think that has todo with YT breaking us so that will probably be fixed in #5679. Lol cant read ty @PikachuEXE

[PikachuEXE]

As YouTube doesn't provide any published dates on the shorts tab, we unfortunately cannot cache the data from that tab, however we can still cache the videos, live and community tabs.