Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update RSS tooltip #5753

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Update RSS tooltip #5753

merged 1 commit into from
Sep 28, 2024

Conversation

efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc commented Sep 28, 2024 •
edited
Loading

Update RSS tooltip

Pull Request Type

  • Documentation

Related issue

#5716

Description

Add info about missing community posts in the tooltip of the RSS toggle

Additional context

This does not fully close the issue imo. To fully close the issue I suggest the following:

  • To prevent confusion DONT hide the community tab when RSS is enabled through the setting or forced by the app instead display a proper message on the community tab. When users see that message they can decide themselves what they want to do about it. Nothing, Hiding the tab through the Distraction Free Settings or lowering subscription count so they can see the posts.

@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 28, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 28, 2024 00:22
@FreeTubeBot FreeTubeBot merged commit 9f697c9 into FreeTubeApp:development Sep 28, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChunkyProgrammer ChunkyProgrammer ChunkyProgrammer approved these changes

@absidue absidue absidue approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@efb4f5ff-1298-471a-8973-3d47447115dc @PikachuEXE @absidue @ChunkyProgrammer @FreeTubeBot