Change the Proxy Videos Through Invidious setting to only apply when using the Invidious API #5758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…using the Invidious API
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
Implemented |
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Sep 29, 2024
PikachuEXE
approved these changes
Sep 30, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 3, 2024
* development: (49 commits) Translated using Weblate (Japanese) Translated using Weblate (French) Fix long comments overflowing and breaking the layout (FreeTubeApp#5774) Cleanup unused code in the store (FreeTubeApp#5776) Revert "Larger search/URL bar (FreeTubeApp#5348)" (FreeTubeApp#5773) Fix loading from search cache failing when no features are selected (FreeTubeApp#5775) Bump lefthook from 1.7.15 to 1.7.17 (FreeTubeApp#5768) Bump webpack from 5.94.0 to 5.95.0 (FreeTubeApp#5770) Bump sass from 1.79.3 to 1.79.4 (FreeTubeApp#5771) Translated using Weblate (Chinese (Traditional Han script)) Change the Proxy Videos Through Invidious setting to only apply when using the Invidious API (FreeTubeApp#5758) Support copying post links from the context menu (FreeTubeApp#5760) Local API: Fix error when a community post has no likes (FreeTubeApp#5759) Translated using Weblate (English (United Kingdom)) Translated using Weblate (Dutch) Translated using Weblate (Swedish) Do not overwrite cache entries when hitting RSS ratelimits (FreeTubeApp#5756) Translated using Weblate (Czech) Translated using Weblate (Hungarian) Translated using Weblate (Hungarian) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the Proxy Videos Through Invidious setting to only apply when using the Invidious API
Pull Request Type
Description
Users have often been confused that the
Proxy Videos Through Invidioussetting applies to the local API too. Additionally if you have that setting turned on and the Invidious instance you are using is having problems you just end up in an endless loop of Invidious failing (deceptively the error message gets shown as aLocal API errorbut it's still Invidious that is causing it).So as discussed in the Matrix chat this pull request changes the
Proxy Videos Through Invidioussetting to only apply to the Invidious API. I haven't changed anything about the settings page other than the tooltip text, as it will still proxy the video if you fallback to the Invidious API when the local API errors.I have updated the tooltip text for most languages, but skipped the right-to-left languages as editing the strings in those files is messy if you don't understand the language, so I'll leave those to the translators on weblate.
Testing
Proxy Videos Through Invidioussetting*.googlevideo.comand not an Invidious instance.Desktop