Fix no comment detection #5879
Merged
Fix no comment detection #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PikachuEXE
requested review from
absidue,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
github-actions
bot
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
linked an issue
6 tasks
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 16, 2024
absidue
approved these changes
Oct 16, 2024
ChunkyProgrammer
approved these changes
Oct 16, 2024
github-actions
bot
removed
the
PR: waiting for review
4 tasks
PikachuEXE
added a commit
to PikachuEXE/FreeTube
that referenced
this pull request
Oct 16, 2024
* development: Translated using Weblate (Polish) ! Fix no comment detection (FreeTubeApp#5879) Fix wrong live stream playlist used for subscriptions (FreeTubeApp#5876) Translated using Weblate (Arabic) Run linter when PRs are made against RC branches
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Type
Related issue
Description
No comment detection introduced in #3231 broken for Local API sometimes due to LuanRT/YouTube.js#782
This PR makes it work like IV API (request and match error message)
Screenshots
Nope
Testing
A. Video with comments
B. Video without comment
C1. Video with comment disabled (Local API)
C2. Video with comment disabled (Invidious API)
Desktop
Additional context