Set download links on Watch even if there are no caption links #5916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
PR: waiting for review
MarmadileManteater
requested review from
PikachuEXE,
ChunkyProgrammer and
kommunarr
absidue
approved these changes
Oct 22, 2024
ChunkyProgrammer
approved these changes
Oct 22, 2024
kommunarr
approved these changes
Oct 22, 2024
github-actions
bot
removed
the
PR: waiting for review
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set download links on Watch page even if there are no caption links
Pull Request Type
Description
The line
this.downloadLinks = downloadLinksis only being ran when videos have captions. This PR addresses this by moving this line outside of theresult.captionscondition.Screenshots
on a video with no caption tracks:
Testing
(you could also test a video with captions to make sure it still shows the download links icon button [ex: https://youtu.be/-lNE26RHH7E ])