Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subscription tab hiding not working on launch #5925

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix subscription tab hiding not working on launch #5925

merged 1 commit into from
Oct 24, 2024

Conversation

absidue
Copy link
Member

@absidue absidue commented Oct 23, 2024

Fix subscription tab hiding not working on launch

Pull Request Type

  • Bugfix

Related issue

closes #5883

Description

This pull request fixes the "Hide Subscription (Videos, Live, Shorts and Community)" settings not working on launch correctly on launch, as it was only checking those settings for the tab bar and when you came back to the subscriptions page, but not for the tab content.

Testing

  1. Make sure you have content on the videos subscriptions tab (either refresh to make sure the cache is fully populated or turn on automatic subscription fetching).
  2. Turn on the "Hide Subscription Videos" setting in the "Distraction Free" settings section
  3. Restart FreeTube
  4. You should see the shorts tab and content from it. Previously you would have seen the shorts tab selected but the video list from the videos tab.

Desktop

  • OS: Windows
  • OS Version: 10
  • FreeTube version: b9adcb3

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) October 23, 2024 20:36
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 23, 2024
@FreeTubeBot FreeTubeBot merged commit 4ebd373 into FreeTubeApp:development Oct 24, 2024
5 checks passed
@github-actions github-actions bot removed the PR: waiting for review For PRs that are complete, tested, and ready for review label Oct 24, 2024
@absidue absidue deleted the fix-hiding-subscription-tabs branch October 24, 2024 13:08
Soham456 pushed a commit to Soham456/FreeTube that referenced this pull request Dec 5, 2024
@absidue @Soham456
Fix subscription tab hiding not working on launch (FreeTubeApp#5925)
05f0b9f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kommunarr kommunarr kommunarr approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@ChunkyProgrammer ChunkyProgrammer Awaiting requested review from ChunkyProgrammer

@MarmadileManteater MarmadileManteater Awaiting requested review from MarmadileManteater

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Distraction Free option Hide Subscriptions Videos does not work
5 participants
@absidue @PikachuEXE @efb4f5ff-1298-471a-8973-3d47447115dc @kommunarr @FreeTubeBot