Migrate FtListChannel and FtListHashtag to the composition API #5945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
added
the
DO NOT MERGE UNTIL AFTER RELEASE
github-actions
bot
added
the
PR: waiting for review
ChunkyProgrammer
removed
the
DO NOT MERGE UNTIL AFTER RELEASE
efb4f5ff-1298-471a-8973-3d47447115dc
previously approved these changes
Oct 27, 2024
|
Noticed this pre-existing issue when searching
|
kommunarr
previously approved these changes
Oct 27, 2024
github-actions
bot
added
PR: merge conflicts / rebase needed
and removed
PR: waiting for review
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
absidue
dismissed stale reviews from kommunarr and efb4f5ff-1298-471a-8973-3d47447115dc
via
f491d4e
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
absidue
added
the
PR: waiting for review
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Oct 28, 2024
ChunkyProgrammer
approved these changes
Oct 28, 2024
kommunarr
approved these changes
Oct 28, 2024
github-actions
bot
removed
the
PR: waiting for review
PikachuEXE
added a commit
to Zeabyte/FreeTube-0
that referenced
this pull request
Oct 29, 2024
* development: (225 commits) Invidious API: Add support for auto-dubbed audio tracks (FreeTubeApp#5943) Fix settings password handling (FreeTubeApp#5988) Translated using Weblate (Serbian) Translated using Weblate (Breton) Translated using Weblate (Toki Pona) Translated using Weblate (Breton) Translated using Weblate (Toki Pona) Translated using Weblate (Icelandic) Bump youtubei.js from 10.5.0 to 11.0.0 (FreeTubeApp#5996) Bump shaka-player from 4.11.10 to 4.11.11 (FreeTubeApp#5995) Bump eslint-plugin-vue from 9.29.1 to 9.30.0 in the eslint group (FreeTubeApp#5994) Translated using Weblate (Latvian) Translated using Weblate (Toki Pona) Translated using Weblate (Icelandic) Translated using Weblate (Hungarian) Translated using Weblate (Toki Pona) Translated using Weblate (Icelandic) Translated using Weblate (Hungarian) Migrate FtListChannel and FtListHashtag to the composition API (FreeTubeApp#5945) Fix issue FreeTubeApp#5969 (FreeTubeApp#5970) ...
Soham456
pushed a commit
to Soham456/FreeTube
that referenced
this pull request
Dec 5, 2024
SuperAKWA
pushed a commit
to SuperAKWA/FreeTube
that referenced
this pull request
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate FtListChannel and FtListHashtag to the composition API
Pull Request Type
Description
This pull request migrates the FtListChannel and FtListHashtag components from the options API to the SFC composition API. I renamed a few variables to names that I thought were more suitable e.g.
parsedVideoCounttoformattedVideoCountas that variable contains the video count formatted according to the users locale. I also decided to move the parsing of the subscriber count string for the local API from the FtListChannel component to thesrc/renderer/helpers/api/local.js, as it seemed weird that that we were parsing the subscriber count in the component when the rest of the parsing was insrc/renderer/helpers/api/local.js.Testing
Search for hashtags (e.g.
#shorts,#asmr) and channels (LinusTechTips, you might want to set the type filter to channels here so that you don't have to weed through all the video results first) and make sure they are displayed correctly in search results.Desktop