Add support for upcoming livestream trailers #6375
Draft
+89
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
reviewed
Dec 13, 2024
Comment on lines
+45
to
+76
| v-if="!isLoading && isUpcoming && playabilityStatus === 'OK'" | ||
| class="trailer premiereDate" | ||
| > | ||
| <font-awesome-icon | ||
| :icon="['fas', 'satellite-dish']" | ||
| class="premiereIcon" | ||
| /> | ||
| <p | ||
| v-if="upcomingTimestamp !== null" | ||
| class="premiereText" | ||
| > | ||
| <span | ||
| class="premiereTextTimeLeft" | ||
| > | ||
| {{ $t("Video.Premieres") }} {{ upcomingTimeLeft }} | ||
| </span> | ||
| <br> | ||
| <span | ||
| class="premiereTextTimestamp" | ||
| > | ||
| {{ upcomingTimestamp }} | ||
| </span> | ||
| </p> | ||
| <p | ||
| v-else | ||
| class="premiereText" | ||
| > | ||
| {{ $t("Video.Starting soon, please refresh the page to check again") }} | ||
| </p> | ||
| </div> | ||
| <div | ||
| v-else-if="!isLoading && (isUpcoming || errorMessage)" |
There was a problem hiding this comment.
I'm on mobile so I might be missing something glaringly obvious but this looks like it mostly duplicates upcoming video the code below it.
There was a problem hiding this comment.
It's slightly different. It moves the premiere timestamp below the video and gets rid of the video thumbnail. I'll see if i can use some css classes and v-if statements to avoid the code duplication
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for upcoming livestream trailers
Pull Request Type
Related issue
LuanRT/YouTube.js#842
Description
This will be difficult to test but some upcoming videos have trailers to view before the stream is uploaded. For example, this is an upcoming video that has a trailer: https://youtu.be/t28qkILDe58 (it will most likely be uploaded by the time this PR gets reviewed).
Screenshots
Upcoming video with trailer:
Upcoming video without trailer:
Other video (movie) with trailer:
Testing
Desktop