Re-export unchanged datastore classes instead of wrapping them #6456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc,
ChunkyProgrammer,
kommunarr and
MarmadileManteater
github-actions
bot
added
the
PR: waiting for review
PikachuEXE
approved these changes
Dec 27, 2024
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Dec 27, 2024
ChunkyProgrammer
approved these changes
Dec 27, 2024
github-actions
bot
removed
the
PR: waiting for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-export unchanged datastore classes instead of wrapping them
Pull Request Type
Description
Shaves 1902 bytes off the web build and slightly improves performance in that build as the stores will directly interact with the base datastore classes whenever possible, this mostly benefits the FreeTubeAndroid fork but also helps us, as it saves some work for developers making changes to the datastores.
We still need all the classes in the Electron file as those make IPC calls to the main process which then calls the base handlers.
Desktop