Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to change volume level with scroll wheel #716

Closed
wants to merge 5 commits into from
Closed

Added ability to change volume level with scroll wheel #716

wants to merge 5 commits into from

Conversation

TDDR
Copy link
Contributor

@TDDR TDDR commented Oct 24, 2020


Added ability to change volume level with scroll wheel

Pull Request Type
Please select what type of pull request this is:

  • Bugfix
  • Feature Implementation

Related issue
Fixes #573

Description
As the title suggests, I was finally able to figure out how to enable volume scroll on hover. Now, when the user hovers over the volume panel the user can change the volume with a wheel scroll.

Desktop (please complete the following information):

  • OS: Windows 10
  • OS Version: 1909
  • FreeTube version: 0.9

Additional context
There is one thing that I found in testing that I am unsure if you would consider it a bug or a feature. If the user clicks on the mute button, that locks out the ability to wheel scroll the volume back on. The user must manually click the mute button again to unmute.

@Svallinn
Copy link
Member

Svallinn commented Oct 24, 2020

Apparently, the mouse wheel still changes the volume while the video is muted.
e.g. if you are at 50% volume, mute, scroll up and unmute, you can put it at 100% and can easily have it blasting your ears accidentally.
This is merely a suggestion, but try adding a condition that prevents the mouse wheel from modifying the sound if the video is muted.

@GilgusMaximus
Copy link
Contributor

But that depends on the user. I would expect the program to do that honestly.

@Svallinn
Copy link
Member

Svallinn commented Oct 24, 2020

Yeah, I guess it does differ from person to person, it's probably fine as it is.
I'll leave it up to TDDR to make that call.

@TDDR
Copy link
Contributor Author

TDDR commented Oct 24, 2020

Thanks for catching that Synkky. That should be an easy enough condition to check for, but I think I'll leave it up to PrestonN to decide if it's a bug or a feature.

@PrestonN
Copy link
Member

Apologies for the delayed response on this.

I would say that if the volume is muted and the user scrolls up, this should unmute the volume and set it to 0.05 (whatever is the lowest increment). Ideally it shouldn't be changing the volume in the background where the user doesn't understand what's being changed. This should be fairly simple to implement.

Let me know if you have any questions about it.

@TDDR
Copy link
Contributor Author

TDDR commented Oct 26, 2020

Finished those amendments. Let me know if it's up to par!

@TDDR
Copy link
Contributor Author

TDDR commented Oct 27, 2020

Sorry, I messed up my local branches. I'm gonna re-submit a PR for this.

@TDDR TDDR closed this Oct 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adjusting volume with scroll wheel is not working.
4 participants