-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added ability to change volume level with scroll wheel #716
Conversation
Apparently, the mouse wheel still changes the volume while the video is muted. |
But that depends on the user. I would expect the program to do that honestly. |
Yeah, I guess it does differ from person to person, it's probably fine as it is. |
Thanks for catching that Synkky. That should be an easy enough condition to check for, but I think I'll leave it up to PrestonN to decide if it's a bug or a feature. |
Apologies for the delayed response on this. I would say that if the volume is muted and the user scrolls up, this should unmute the volume and set it to 0.05 (whatever is the lowest increment). Ideally it shouldn't be changing the volume in the background where the user doesn't understand what's being changed. This should be fairly simple to implement. Let me know if you have any questions about it. |
Finished those amendments. Let me know if it's up to par! |
Sorry, I messed up my local branches. I'm gonna re-submit a PR for this. |
Added ability to change volume level with scroll wheel
Pull Request Type
Please select what type of pull request this is:
Related issue
Fixes #573
Description
As the title suggests, I was finally able to figure out how to enable volume scroll on hover. Now, when the user hovers over the volume panel the user can change the volume with a wheel scroll.
Desktop (please complete the following information):
Additional context
There is one thing that I found in testing that I am unsure if you would consider it a bug or a feature. If the user clicks on the mute button, that locks out the ability to wheel scroll the volume back on. The user must manually click the mute button again to unmute.