Skip to content
This repository has been archived by the owner on Sep 20, 2023. It is now read-only.

small refactor #66

Merged
merged 2 commits into from
Apr 8, 2022
Merged

small refactor #66

merged 2 commits into from
Apr 8, 2022

Conversation

ChunkyProgrammer
Copy link
Member

Summary of Changes:

  • Reduces the lines of codes to increase readability
  • Gets rid of querystring dependency
  • Upgrades axios
  • Displays test coverage when tests are ran
  • Removed unused methods/properties
  • Deduplicated some code
  • Should also fix the issue with Conditional error - breaking results #65

Next Steps (Once this gets merged I will):

  • try to get the code coverage to be higher by adding more tests.
  • Look into adding mocked tests on top of the tests we have with real data

@PrestonN PrestonN enabled auto-merge (squash) April 7, 2022 12:50
@PrestonN PrestonN merged commit b128a77 into FreeTubeApp:development Apr 8, 2022
PrestonN
PrestonN approved these changes Apr 8, 2022
View reviewed changes
Copy link
Member

@PrestonN PrestonN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@PikachuEXE PikachuEXE PikachuEXE approved these changes

@PrestonN PrestonN PrestonN approved these changes

@efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc efb4f5ff-1298-471a-8973-3d47447115dc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ChunkyProgrammer @PikachuEXE @PrestonN @efb4f5ff-1298-471a-8973-3d47447115dc