This repository has been archived by the owner on Sep 20, 2023. It is now read-only.
Add support for bold, italics and strikethrough formatting #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absidue
requested review from
PikachuEXE,
efb4f5ff-1298-471a-8973-3d47447115dc and
ChunkyProgrammer
|
The CI faîlures aren't caused by this PR, looks like YouTube changed the JSON so the owner reply checks are failing. |
Merged
1 task
efb4f5ff-1298-471a-8973-3d47447115dc
approved these changes
Aug 15, 2022
ChunkyProgrammer
approved these changes
Aug 16, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds support for bold, italics and strikethrough formatting in comments. It also fixes text runs with only whitespace being turned into new lines e.g.
" ".The way this is written it should correctly format text fragments that have multiple types of formatting applied. I haven't been able to find a comment to test that though.
FreeTube PR: FreeTubeApp/FreeTube#2475
Screenshots (if appropriate)
before:
after:
Testing (for code that is not small enough to be easily understandable)
The comments under this video are a good place to test this PR (taken from this article)
https://www.youtube.com/watch?v=OqiXFXlYFi8
Additional context
I know that the
b,iandstags shouldn't be used anymore but it makes this code a lot simpler, the alternative would be to pass on an array of fragments to FreeTube and let FreeTube do the formatting with CSS.