Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cron queue for processing csv export files. #4

Open
wants to merge 1 commit into
base: feature/port-from-d7
Choose a base branch
from

Conversation

yanniboi
Copy link

No description provided.

Copy link

@andrewbelcher andrewbelcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple minor bits, but looking good!

- gdpr_tasks.gdpr_task_type.gdpr_sar
module:
- file
id: gdpr_task.gdpr_sar.sar_export_assets

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would this be better as a base field? I think we've figured out how to do that at a bundle level? If it get's removed it'll cause lots of problems...

'parent' => $field->getParent(),
];
/* @var \Drupal\file\Plugin\Field\FieldType\FileItem $field_type */
$field_type = $this->fieldTypePluginManager->createInstance($field_definition->getType(), $config);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ouch... this is painful... :( They should really put this on FileFieldItemList...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though we will definitely have a field item by this point on the sar_export field, so could just use that...

$csvs[$data['file']][$data['row_id']] += array_fill_keys(array_keys($csvs[$data['file']]['_header']), '');

// Put our piece of information in place.
$csvs[$data['file']][$data['row_id']][$data['plugin_name']] = $data['value'];

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs updating from the D7 stuff for maybe files.

@yanniboi yanniboi force-pushed the feature/port-from-d7-csv branch from 28f0c19 to d7a69fc Compare June 21, 2018 13:27
@yanniboi yanniboi force-pushed the feature/port-from-d7-csv branch from d7a69fc to 1d91c12 Compare June 21, 2018 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants