Implement imx_vpu_api_enc_get_skipped_frame_info() and imx_vpu_api_enc_get_encoded_frame_ext() stubs for all encoders #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pu_api_enc_get_skipped_frame_info() imx8m-hantro-h1 returns IMX_VPU_API_ENC_RETURN_CODE_INVALID_CALL when imx_vpu_api_enc_get_skipped_frame_info() is called when no frame was actually skipped. imx6-coda currently doesn't return a value from imx_vpu_api_enc_get_skipped_frame_info() at all. As imx6-coda does not support frame skipping, it is consistent to just always return IMX_VPU_API_ENC_RETURN_CODE_INVALID_CALL. Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
…s for all encoders Implement this function for all encoders to fix a linker error in gstreamer-imx. These encoders never return IMX_VPU_API_ENC_OUTPUT_CODE_FRAME_SKIPPED, so we always return IMX_VPU_API_ENC_RETURN_CODE_INVALID_CALL from imx_vpu_api_enc_get_skipped_frame_info(). Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
…ame_ext() Linking gstreamer-imx will fail if imx_vpu_api_enc_get_encoded_frame_ext() is not available. Signed-off-by: Matthias Schiffer <matthias.schiffer@tq-group.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The imx_vpu_api_enc_get_skipped_frame_info and imx_vpu_api_enc_get_encoded_frame_ext must be available during linking of current gstreamer-imx. Make these symbols available for all encoders.
For imx_vpu_api_enc_get_skipped_frame_info(), a stub implementation is added that always returns
IMX_VPU_API_ENC_RETURN_CODE_INVALID_CALL(and the stub for imx6-coda is fixed to have a return value at all to avoid a compiler warning).imx_vpu_api_enc_get_encoded_frame_ext() was only missing for imx8m-hantro dummy_encoder.
Fixes Freescale/gstreamer-imx#328