Skip to content

Commit

Permalink
arm64: dts: imx8mm: Correct WDOG_B pin configuration
Browse files Browse the repository at this point in the history
Different revision of i.MX8MM EVK boards may have different external
pull up registor design, some are enabled while some are NOT, to make
sure the WDOG_B pin works properly, better to enable internal pull up
resistor. Since enabling internal pull up resistor is NOT harmful and
having benefit of flexibility on different board design, just enable
it for all i.MX8MM boards; And schmitt input is NOT necessary for this
WDOG_B output pin, so remove it; Open drain outputs provide more
flexibility to a designer as they can be pulled-up to any voltage found
in the system, so enable it as well.

Signed-off-by: Anson Huang <Anson.Huang@nxp.com>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
  • Loading branch information
Anson-Huang authored and Shawn Guo committed Oct 30, 2020
1 parent 582b6d8 commit b781820
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -437,7 +437,7 @@

pinctrl_wdog: wdoggrp {
fsl,pins = <
MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0xc6
MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
>;
};

Expand Down
2 changes: 1 addition & 1 deletion arch/arm64/boot/dts/freescale/imx8mm-evk.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -468,7 +468,7 @@

pinctrl_wdog: wdoggrp {
fsl,pins = <
MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0xc6
MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
>;
};
};
2 changes: 1 addition & 1 deletion arch/arm64/boot/dts/freescale/imx8mm-var-som.dtsi
Original file line number Diff line number Diff line change
Expand Up @@ -555,7 +555,7 @@

pinctrl_wdog: wdoggrp {
fsl,pins = <
MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0xc6
MX8MM_IOMUXC_GPIO1_IO02_WDOG1_WDOG_B 0x166
>;
};
};

0 comments on commit b781820

Please sign in to comment.