-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optee #2157
Optee #2157
Conversation
Copy latest support from NXP BSP LF6.6.52_2.2.0. Note that clang is disabled in optee-os-fslc.inc, which is copied from meta-arm optee-os.inc. Fixes: Issue 2048 - Upgrade BSP to LF6.6.52_2.2.0 Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have what to comment on this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta-arm does not disable clang see
https://git.yoctoproject.org/meta-arm/tree/meta-arm/recipes-security/optee/optee.inc#n19
it only enables it if meta-clang is part of bblayers and TOOLCHAIN is set which by default is clang but user can set it to clang as well. I think you should reword this and also I see here you are explicitly setting TOOLCHAIN to gcc. It would be good to explain why do we need that while upstream from meta-arm does not.
The release that I'm upstreaming here was tested with an older version of meta-arm where clang is disabled. |
this is for master branch where we are not using clang-18 anymore but we are on clang-20, so I would think it I can help to fix if there is anything there to fix. |
Clang is on version 20 now, so the disablement of it and the patches for it are no longer needed. Signed-off-by: Tom Hochstein <tom.hochstein@nxp.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
look ok
I built only, no runtime test. The clang patches failed to apply with the update, and I didn't know how to fix them, so I disabled them. Note that clang is currently disabled anyway.