-
Notifications
You must be signed in to change notification settings - Fork 110
Unit tests under Windows partly fail #647
Comments
Does this repository fix the database test failures? https://github.com/wigglier/freeseer/tree/484-unit-test-and-refactor |
Thanks for the suggestion @wigglier. @promm you can get that branch like this
|
@wigglier @dideler
The detailed doc can be seen: http://promm.github.io/freeseer/doc/freeseer_test_after619.txt |
The ElementNotFound errors sounds like you're missing GStreamer plugins which will be resolved once you install the missing plugins. One of the plugins at least is the "rtmpsink" plugin. The "/tmp" value error is failing because something in the config code is hardcoding a Unix path which is invalid for Windows we should be using Python's tmpdir module. I'm not sure what's the cause of the "AssertionError: False is not true" errors but they seem to be coming from the framework/config module. The "assert talk_id == '1'" coming from the test test_get_presentation_id is failing likely because of the config situation mentioned earlier with the hardcoded paths that are invalid on Windows. The "assert ['Title,Speak...,EndTime\r\n'] == ['Title,Speake...fault,,,\r\n']" error is because you updated the code and didn't clear your ~/.freeseer configuration directory. Looks like someone changed the database format so you need to clear the configuration files to reset the database (or just clear the database file). All of the database related errors are probably due to this. The youtube test code expected = { 'client_secrets': '{}/.freeseer/client_secrets.json'.format(home), 'video_directory': '{}/Videos'.format(home), 'oauth2_token': '{}/.freeseer/oauth2_token.json'.format(home) } Is hardcoded with Unix style system paths, we should be using os.path.join in Python here so that it's cross platform compatible. |
It looks like all the database issues are failing because the QSQLITE driver cannot be loaded in
I am looking for a solution, but I am not having luck. edit:
@promm do you get the above output from running the two commands in your Python interpretter? |
@zxiiro |
One of our previous students worked on getting the rtmp plugin working on Windows. See: http://jonathanasdf.wordpress.com/2012/11/09/building-rtmpsink-plugin-for-gstreamer-on-windows/ |
@promm Do you have the QSQLITE driver? I don't see it listed as a dependency in the Windows development setup guide, but it is listed in the linux setup guide as http://qt-project.org/doc/qt-4.8/sql-driver.html#qsqlite |
@wigglier I am not sure about that, since I only installed the packages that are listed on the web page. I will try it again after installing that. |
@promm if you scroll up, you'll see some commands that @wigglier posted in his edit to check if you have the driver. |
@dideler @wigglier |
@dideler @wigglier |
@zxiiro Do I need to svn the ossbuild onto my local machine and build it with the patch he gave? |
I don't know why they don't automatically include it in the Windows release but on Linux it's part of gstreamer-bad-plugins (maybe this is why?). Anyway this is a plugin we are already supporting so removing support for it doesn't make sense at this point and video streaming capabilities was one of our most requested features. If you don't have Visual Studio to build that's ok, just ignore this plugin then I would't expect you to spend too much time spinning your wheels on getting a VS environment setup this late in the year. Maybe we can but a check for this plugin when run on Windows systems and skip it during testing? |
@zxiiro |
@dideler |
You'll need to open a new PR to close this issue. |
@dideler |
@wigglier already switched it to use pytest in #642, I'll try to get that merged today after work. Please remind me if I forget. |
Thanks. Just getting #642 merge-ready now, discovered a few things that still needed to be fixed. |
Partly fix Freeseer#647. The rmtp plugin is not included in GStreamer for Win32, so the test based on it can cause problems. This fix will skip these tests.
@wigglier |
Partly fix Freeseer#647. The RMTP plugin is not included in GStreamer for Win32, so the test based on it can cause problems. This fix will skip these tests.
Partly fix Freeseer#647. The RTMP plugin is not included in GStreamer for Win32, so the test based on it can cause problems. This fix will skip these tests.
Partly fix Freeseer#647. The RTMP plugin is not included in GStreamer for Win32, so the test based on it can cause problems. This fix will skip these tests.
By running
under Windows, we get 12 failures.
Here is the full output of the test:
http://promm.github.io/freeseer/doc/freeseer_test_windows.txt
The text was updated successfully, but these errors were encountered: