This repository has been archived by the owner on May 28, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 110
Construct a new database schema for the presentation table that better handles timestamps #667
Labels
Comments
#619 (comment) provides an example of how the ambiguous schema creates a bit of confusion. |
This is handled by QDateTime / QDate / QTime I can't recall which or if all combinations of those are used but as long as your date format is accepted by those Qt will handle the rest. You can probably look up the Qt Docs on those classes to find out what their requirements are. |
http://www.pythoncentral.io/advanced-sqlite-usage-in-python/ mentions that if we have a |
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Nov 28, 2014
…imestamp objects. Replaced references to presentation.{date,startTime,endTime} that use strings with QDateTime objects. Modified the rss and csv reading functions to cast the presentation timestamp fields into QDateTime objects. Modified the csv and rss exporting functions to cast QDateTime objects into strings. Updated several database queries to use Date and DateTime variables instead of just using DateTime. Added prepared queries to replace existing queries involving the date. This was needed since format does not work with a QDateTime object. fix Freeseer#667
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 4, 2014
…imestamp objects. Replaced references to presentation.{date,startTime,endTime} that use strings with QDateTime objects. Modified the rss and csv reading functions to cast the presentation timestamp fields into QDateTime objects. Modified the csv and rss exporting functions to cast QDateTime objects into strings. Updated several database queries to use Date and DateTime variables instead of just using DateTime. Added prepared queries to replace existing queries involving the date. This was needed since format does not work with a QDateTime object. fix Freeseer#667
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 4, 2014
- Remove test methods that only check function return types - Create resources folder for common test data like test rss feeds - Fix database.py query bugs - Add database folder for database related tests - Refactor common database fixtures into the database conftest file - Refactor comments in database.py - Refactor queries in database.py to have better style and sanitization - Add comments and examples of the presentation time stamps - Remove unused functions from database.py - Add httpretty mock tests for database.py - Add a database schema upgrade test - Add tests that check multiple scenarios of each method in database.py - Replace string % operators with calls to format for nonlog string formatting - Remove several try/finally statements and replaced them with 'with's - Fix an exception logging statement which referred to an out of scope value - Add failure and presentation equality and inequality comparison functions - Add example of parameterized test with fixtures - Fix relative path bug from linux convention to multi-platform in test_rss_feedparser.py - Add fixtures based on summer camp 2010 and 2011 stored data - Add rough copy of new schema Related Freeseer#484 Related Freeseer#651 Related Freeseer#667 Related Freeseer#670
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 4, 2014
- Remove test methods that only check function return types - Create resources folder for common test data like test rss feeds - Fix database.py query bugs - Add database folder for database related tests - Refactor common database fixtures into the database conftest file - Refactor comments in database.py - Refactor queries in database.py to have better style and sanitization - Add comments and examples of the presentation time stamps - Remove unused functions from database.py - Add httpretty mock tests for database.py - Add a database schema upgrade test - Add tests that check multiple scenarios of each method in database.py - Replace string % operators with calls to format for nonlog string formatting - Remove several try/finally statements and replaced them with 'with's - Fix an exception logging statement which referred to an out of scope value - Add failure and presentation equality and inequality comparison functions - Add example of parameterized test with fixtures - Fix relative path bug from linux convention to multi-platform in test_rss_feedparser.py - Add fixtures based on summer camp 2010 and 2011 stored data - Add rough copy of new schema Related Freeseer#484 Related Freeseer#667 Related Freeseer#670
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 18, 2014
- Remove test methods that only check function return types - Create resources folder for common test data like test rss feeds - Fix database.py query bugs - Add database folder for database related tests - Refactor common database fixtures into the database conftest file - Refactor comments in database.py - Refactor queries in database.py to have better style and sanitization - Add comments and examples of the presentation time stamps - Remove unused functions from database.py - Add httpretty mock tests for database.py - Add a database schema upgrade test - Add tests that check multiple scenarios of each method in database.py - Replace string % operators with calls to format for nonlog string formatting - Remove several try/finally statements and replaced them with 'with's - Fix an exception logging statement which referred to an out of scope value - Add failure and presentation equality and inequality comparison functions - Add example of parameterized test with fixtures - Fix relative path bug from linux convention to multi-platform in test_rss_feedparser.py - Add fixtures based on summer camp 2010 and 2011 stored data - Add rough copy of new schema Related Freeseer#484 Related Freeseer#667 Related Freeseer#670
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 19, 2014
- Remove test methods that only check function return types - Create resources folder for common test data like test rss feeds - Fix database.py query bugs - Add database folder for database related tests - Refactor common database fixtures into the database conftest file - Refactor comments in database.py - Refactor queries in database.py to have better style and sanitization - Add comments and examples of the presentation time stamps - Remove unused functions from database.py - Add httpretty mock tests for database.py - Add a database schema upgrade test - Add tests that check multiple scenarios of each method in database.py - Replace string % operators with calls to format for nonlog string formatting - Remove several try/finally statements and replaced them with 'with's - Fix an exception logging statement which referred to an out of scope value - Add failure and presentation equality and inequality comparison functions - Add example of parameterized test with fixtures - Add fixtures based on summer camp 2010 and 2011 stored data Related Freeseer#484 Related Freeseer#667 Related Freeseer#670
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 19, 2014
Related Freeseer#667 Related Freeseer#484 Related Freeseer#671
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 19, 2014
- Remove test methods that only check function return types - Create resources folder for common test data like test rss feeds - Fix database.py query bugs - Add database folder for database related tests - Refactor common database fixtures into the database conftest file - Refactor comments in database.py - Refactor queries in database.py to have better style and sanitization - Add comments and examples of the presentation time stamps - Remove unused functions from database.py - Add httpretty mock tests for database.py - Add a database schema upgrade test - Add tests that check multiple scenarios of each method in database.py - Replace string % operators with calls to format for nonlog string formatting - Remove several try/finally statements and replaced them with 'with's - Fix an exception logging statement which referred to an out of scope value - Add failure and presentation equality and inequality comparison functions - Add example of parameterized test with fixtures - Add fixtures based on summer camp 2010 and 2011 stored data Related Freeseer#484 Related Freeseer#667 Related Freeseer#670
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 19, 2014
- Remove test methods that only check function return types - Create resources folder for common test data like test rss feeds - Fix database.py query bugs - Add database folder for database related tests - Refactor common database fixtures into the database conftest file - Refactor comments in database.py - Refactor queries in database.py to have better style and sanitization - Add comments and examples of the presentation time stamps - Remove unused functions from database.py - Add httpretty mock tests for database.py - Add a database schema upgrade test - Add tests that check multiple scenarios of each method in database.py - Replace string % operators with calls to format for nonlog string formatting - Remove several try/finally statements and replaced them with 'with's - Fix an exception logging statement which referred to an out of scope value - Add failure and presentation equality and inequality comparison functions - Add example of parameterized test with fixtures - Add fixtures based on summer camp 2010 and 2011 stored data Related Freeseer#484 Related Freeseer#667 Related Freeseer#670
SRomansky
pushed a commit
to SRomansky/freeseer
that referenced
this issue
Dec 27, 2014
- Remove test methods that only check function return types - Create resources folder for common test data like test rss feeds - Fix database.py query bugs - Add database folder for database related tests - Refactor common database fixtures into the database conftest file - Refactor comments in database.py - Refactor queries in database.py to have better style and sanitization - Add comments and examples of the presentation time stamps - Remove unused functions from database.py - Add httpretty mock tests for database.py - Add a database schema upgrade test - Add tests that check multiple scenarios of each method in database.py - Replace string % operators with calls to format for nonlog string formatting - Remove several try/finally statements and replaced them with 'with's - Fix an exception logging statement which referred to an out of scope value - Add failure and presentation equality and inequality comparison functions - Add example of parameterized test with fixtures - Add fixtures based on summer camp 2010 and 2011 stored data Related Freeseer#484 Related Freeseer#667 Related Freeseer#670
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
The current database schema:
Does not describe the Date, StartTime, or Endtime that Freeseer expects. It would be useful to have a well defined meaning for what each field is supposed to contain.
Some of the current code in Freeseer expects dates of the format
2010-05-14T10:45
and has resulted in the following code being added:Such code would need to be refactored when a new schema was implemented. The above code also uses the same timestamp format for the
presentation.date
andpresentation.startTime
fields.Related #634, #619, #484
The text was updated successfully, but these errors were encountered: