Converting to Python 3

[sunn-e]

Using 2to3.
Creating .bak for backups
Let me know if there are any errors. I am reviewing this currently.

[pep8speaks]

Hello @sunn-e! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

• In the file src/freeseer/framework/database.py:

Line 244:30: E128 continuation line under-indented for visual indent
Line 245:30: E128 continuation line under-indented for visual indent
Line 246:30: E128 continuation line under-indented for visual indent
Line 247:30: E128 continuation line under-indented for visual indent
Line 248:30: E128 continuation line under-indented for visual indent
Line 249:30: E128 continuation line under-indented for visual indent
Line 250:30: E128 continuation line under-indented for visual indent
Line 251:30: E128 continuation line under-indented for visual indent
Line 268:13: E128 continuation line under-indented for visual indent

• In the file src/freeseer/framework/qt_key_grabber.py:

Line 62:80: E501 line too long (99 > 79 characters)
Line 64:80: E501 line too long (88 > 79 characters)

• In the file src/freeseer/frontend/cli.py:

Line 80:80: E501 line too long (80 > 79 characters)
Line 110:80: E501 line too long (96 > 79 characters)
Line 158:80: E501 line too long (85 > 79 characters)
Line 254:80: E501 line too long (91 > 79 characters)

• In the file src/freeseer/frontend/configtool/configtool.py:

Line 228:80: E501 line too long (124 > 79 characters)
Line 240:80: E501 line too long (110 > 79 characters)
Line 499:80: E501 line too long (126 > 79 characters)
Line 505:80: E501 line too long (139 > 79 characters)
Line 564:80: E501 line too long (126 > 79 characters)
Line 570:80: E501 line too long (139 > 79 characters)

• In the file src/freeseer/frontend/qtcommon/AboutWidget.py:

Line 141:80: E501 line too long (81 > 79 characters)
Line 147:80: E501 line too long (95 > 79 characters)
Line 148:80: E501 line too long (91 > 79 characters)
Line 149:80: E501 line too long (92 > 79 characters)
Line 150:80: E501 line too long (87 > 79 characters)

• In the file src/freeseer/frontend/record/RecordingController.py:

Line 77:80: E501 line too long (104 > 79 characters)

• In the file src/freeseer/frontend/record/record.py:

Line 238:80: E501 line too long (92 > 79 characters)
Line 366:80: E501 line too long (96 > 79 characters)
Line 412:80: E501 line too long (92 > 79 characters)
Line 583:80: E501 line too long (99 > 79 characters)

• In the file src/freeseer/frontend/reporteditor/reporteditor.py:

Line 167:80: E501 line too long (81 > 79 characters)
Line 168:80: E501 line too long (85 > 79 characters)
Line 171:80: E501 line too long (81 > 79 characters)
Line 172:80: E501 line too long (80 > 79 characters)

• In the file src/freeseer/frontend/talkeditor/talkeditor.py:

Line 407:80: E501 line too long (81 > 79 characters)

• In the file src/freeseer/frontend/upload/youtube.py:

Line 54:80: E501 line too long (94 > 79 characters)
Line 56:80: E501 line too long (90 > 79 characters)
Line 58:80: E501 line too long (109 > 79 characters)
Line 109:80: E501 line too long (85 > 79 characters)

• In the file src/freeseer/plugins/audioinput/jackaudiosrc/__init__.py:

Line 44:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/audioinput/pulsesrc/__init__.py:

Line 47:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/audiomixer/audiopassthrough/__init__.py:

Line 46:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/audiomixer/multiaudio/__init__.py:

Line 44:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/importer/csv_importer.py:

Line 62:80: E501 line too long (89 > 79 characters)
Line 66:80: E501 line too long (91 > 79 characters)

• In the file src/freeseer/plugins/output/audiofeedback/__init__.py:

Line 45:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/output/ogg_icecast/__init__.py:

Line 45:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/output/ogg_output/__init__.py:

Line 46:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/output/videopreview/__init__.py:

Line 45:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/videoinput/desktop/__init__.py:

Line 49:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/videoinput/firewiresrc/__init__.py:

Line 48:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/videoinput/usbsrc/__init__.py:

Line 47:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/videoinput/videotestsrc/__init__.py:

Line 45:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/videomixer/pip/__init__.py:

Line 45:1: E402 module level import not at top of file

• In the file src/freeseer/plugins/videomixer/videopassthrough/__init__.py:

Line 47:1: E402 module level import not at top of file

• In the file src/freeseer/tests/frontend/configtool/test_config_tool.py:

Line 94:80: E501 line too long (87 > 79 characters)

• In the file src/freeseer/tests/frontend/test_cli_talk.py:

Line 72:80: E501 line too long (87 > 79 characters)
Line 73:80: E501 line too long (87 > 79 characters)
Line 74:80: E501 line too long (84 > 79 characters)
Line 75:80: E501 line too long (81 > 79 characters)

Comment last updated at 2019-10-10 07:28:45 UTC

[zxiiro]

The entire point of Git is that it tracks the history of file changes. Creating .bak files is unnecessary and adds noise to a code review.

You can always grab a previous version of the files by git checkout <commit> or if you tag a point for reference you can always get back to that tag.

[zxiiro]

Please remove all the .bak files. Git's purpose is to track changes to files so backing up files is an entirely pointless in a PR.

[sunn-e]

Okay @zxiiro . I will do the changes.