-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: enhanced Versioning System with Codename + SemVer #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaeeraa <ilhainshakov@yandex.ru>
1 task
Signed-off-by: kaeeraa <ilhainshakov@yandex.ru>
Signed-off-by: kaeeraa <ilhainshakov@yandex.ru>
could you squish them after that? thx |
it will |
ping as soon as checks end, 'k? |
Signed-off-by: kaeeraa <ilhainshakov@yandex.ru>
new commit |
fvcked up again |
ill open new pr when fix everything |
auto-merge was automatically disabled
January 15, 2025 20:57
Pull request was closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[0] : Freesm
FreesmLauncher component
[2] : Enhancement
Improvement to existing functionality.
[3] : Priority: High
High-priority task.
[4] : Complexity: Easy
A simple task requiring minimal effort.
[6] : Platform: Cross-Platform
Tasks affecting all platforms.
[8] : User: Developers
Tasks aimed at developers.
[8] : User: End-Users
Tasks aimed at end-users.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request enhances the versioning system by introducing:
Details of Changes
CMake Configuration
Launcher_VERSION_PATCH
for patch-level versioning.Launcher_VERSION_CODENAME
for descriptive release names.Launcher_VERSION_NAME
now includes codename and full semantic versioning.Launcher_VERSION_NAME4
andLauncher_VERSION_NAME4_COMMA
accordingly.Build Specification (
Build.spec
)Version
to reflect the new format, incorporating codename and patch level.Codebase Updates
BuildConfig.cpp.in
:VERSION_PATCH
andVERSION_CODENAME
.Config::versionString()
to include the new versioning format.BuildConfig.h
:VERSION_PATCH
andVERSION_CODENAME
.PrismUpdater.cpp
:run()
method for consistency with the updated versioning system.New Version Format
For example:
Sequoia
1.0.0
This will result in:
Sequoia 1.0.0
Benefits
Testing
Please review the proposed changes and provide feedback. If everything aligns with the project goals, kindly approve this pull request.