Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2598] Problematic SVG on Firefox #2623

Merged
merged 2 commits into from
Sep 22, 2024
Merged

[#2598] Problematic SVG on Firefox #2623

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
47da499
Correct markup for firefox compatibility. Remove duplication of skip.
Changh341 Sep 22, 2024
201c2b5
Revert sizing changes on SVG markup. Scaled down the skip icon hoveri…
Changh341 Sep 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file removed assets/autoload/phaser/interface/skip.png
View file
Open in desktop
Binary file not shown.
1 change: 1 addition & 0 deletions assets/autoload/phaser/interface/skip.svg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
1 change: 0 additions & 1 deletion assets/icons/skip.svg
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/creature.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2087,7 +2087,7 @@ class CreatureSprite {
// Add "Skip turn" icon
const skipTurnIcon = this._phaser.add.sprite(0, 50, 'skip');
skipTurnIcon.anchor.setTo(0.5, 0.7); // Give a bit more vertical space
skipTurnIcon.setScaleMinMax(0.63, 0.63, 0.63, 0.63);
skipTurnIcon.setScaleMinMax(0.15, 0.15, 0.15, 0.15);
skipTurnIcon.alpha = 0;
skipTurnIcon.data.hintType = hintType;
skipTurnIcon.data.tweenAlpha = null;
Expand Down
16 changes: 8 additions & 8 deletions src/style/styles.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,7 +426,7 @@
}

.button#skip {
background-image: url('~assets/icons/skip.svg');
background-image: url('~assets/autoload/phaser/interface/skip.svg');
}

.button#delay {
Expand Down Expand Up @@ -2067,10 +2067,10 @@ input {

#brandlogo {
height: 100vh;
width: 100vw;
display: flex;
align-items: center;
justify-content: center;
width: 100vw;
display: flex;
align-items: center;
justify-content: center;
&.hide {
display: none;
}
Expand All @@ -2097,16 +2097,16 @@ input {
background-position-y: top;
background-size: 50%;
width: 50%;
height:250px;
height: 250px;
max-width: 1000px;
margin-top: 12%;

@media (max-aspect-ratio: 16/9) {
margin-top:10%;
margin-top: 10%;
}

@media (orientation: portrait) {
margin-top:5%;
margin-top: 5%;
}

@media screen and (min-height: 300px) {
Expand Down
Loading