Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feed attributes only for admin #1905

Merged
merged 2 commits into from
May 29, 2018
Merged

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented May 29, 2018

@Alkarex Alkarex added this to the 1.11.0 milestone May 29, 2018
@Alkarex
Copy link
Member Author

Alkarex commented May 29, 2018

cURL feed options can be problematic, due to partial feed caching shared between users.
Enabling only for admin users for now.

@Frenzie
Copy link
Member

Frenzie commented May 29, 2018

What about the SSL?

@Alkarex
Copy link
Member Author

Alkarex commented May 29, 2018

@Frenzie timeout and SSL are both some cURL options. Both options risk to affect other users.

@Frenzie
Copy link
Member

Frenzie commented May 29, 2018

I see. At a glance only timeout made sense to me as something that could be problematic on the server side.

@Alkarex
Copy link
Member Author

Alkarex commented May 29, 2018

Yes, for instance with/without SSL could very well retrieve two different version, or retrieve a malicious content (instead of nothing) if someone disables SSL.

@Alkarex Alkarex merged commit 4ec1eba into FreshRSS:dev May 29, 2018
@Alkarex Alkarex deleted the feed-attributes-for-admin branch May 29, 2018 17:11
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
* Feed attributes only for admin

FreshRSS#1838

* Changelog 1905

FreshRSS#1905
mdemoss pushed a commit to mdemoss/FreshRSS that referenced this pull request Mar 25, 2021
* Feed attributes only for admin

FreshRSS#1838

* Changelog 1905

FreshRSS#1905
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants