tec: Provide a Minz_Mailer class #2476
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `_path` method is more powerful since it allows to choose the file extension. It is also Minz_Request-agnostic, which is useful to reuse the Minz_View class in other places. `change_view` is now deprecated and a warning is logged if we use it.
Frenzie
reviewed
Aug 2, 2019
marienfressinaud
force-pushed
the
tec/provide-minz-mailer
branch
from
c3cc53d
to
d43665b
Compare
|
Indeed! I just disabled the linter on the |
4 tasks
|
For some reason, when PHPMailer has a problem, it creates a file under |
It uses PHPMailer under the hood and only supports PHP >= 5.5
marienfressinaud
force-pushed
the
tec/provide-minz-mailer
branch
from
d43665b
to
e39671a
Compare
|
Fixed, it's just that I don't know how to concatenate two strings in PHP :D (I used a |
|
It's probably because with |
|
@marienfressinaud what's the status of this PR? Is it ready to be merged into dev? |
10 tasks
Alkarex
reviewed
Aug 14, 2019
Alkarex
reviewed
Aug 14, 2019
Merged
javerous
pushed a commit
to javerous/FreshRSS
that referenced
this pull request
Jan 20, 2020
* Add Minz_View::_path method (replace change_view) The `_path` method is more powerful since it allows to choose the file extension. It is also Minz_Request-agnostic, which is useful to reuse the Minz_View class in other places. `change_view` is now deprecated and a warning is logged if we use it. * Provide a Minz_Mailer to send emails It uses PHPMailer under the hood and only supports PHP >= 5.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class can be inherited to create Mailers dedicated to some specific tasks. You can have an example of how to use it with what I've done to send validation emails (here and here). It is inspired by how Rails works with emails.
My main concern with this code is that the calls to the SMTP server need to be finished before redirecting the user. We have no systems of parallel queues. But it may be not critical yet and we can go with it for the moment… ?
I also needed to change the
Minz_ViewAPI a bit by replacing thechange_viewmethod by a_pathone. It is nowMinz_Request-agnostic and can support files different than thephtmlones.To merge in
--no-ff