Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git fetch+reset instead of clean+fetch+merge #2625

Merged
merged 1 commit into from
Nov 2, 2019

Conversation

Alkarex
Copy link
Member

@Alkarex Alkarex commented Nov 2, 2019

Fix #2619
Avoid potentially dangerous git clean, and use more robust fetch + reset strategy instead

Fix FreshRSS#2619
Avoid potentially dangerous git clean, and use more robust fetch + reset
strategy instead
@Alkarex Alkarex added this to the 1.15.1 milestone Nov 2, 2019
@Alkarex
Copy link
Member Author

Alkarex commented Nov 2, 2019

Just tested with various conflicts and seems to work fine

Copy link
Member

@marienfressinaud marienfressinaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides my comment, it looks good to me 👍

@Alkarex Alkarex merged commit c277e15 into FreshRSS:dev Nov 2, 2019
@Alkarex Alkarex deleted the git_safer_clean branch November 2, 2019 12:38
Alkarex added a commit to Alkarex/FreshRSS that referenced this pull request Nov 2, 2019
Related to FreshRSS#2625

If for some reasons branches have diverged:, e.g.:

```
$ git status -sb --porcelain remote
## dev...origin/dev [ahead 4, behind 1]
```
@Alkarex Alkarex mentioned this pull request Nov 2, 2019
Alkarex added a commit that referenced this pull request Nov 4, 2019
Related to #2625

If for some reasons branches have diverged:, e.g.:

```
$ git status -sb --porcelain remote
## dev...origin/dev [ahead 4, behind 1]
```
@Alkarex Alkarex mentioned this pull request Nov 4, 2019
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
Fix FreshRSS#2619
Avoid potentially dangerous git clean, and use more robust fetch + reset
strategy instead
javerous pushed a commit to javerous/FreshRSS that referenced this pull request Jan 20, 2020
Related to FreshRSS#2625

If for some reasons branches have diverged:, e.g.:

```
$ git status -sb --porcelain remote
## dev...origin/dev [ahead 4, behind 1]
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants