add lazy loading on favicon #2962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
May 10, 2020
| @@ -94,7 +94,7 @@ | |||
| <a class="dropdown-toggle" data-fweb="<?= $feed->website() ?>"><?= _i('configure') ?></a> | |||
| <?php /* feed_config_template */ ?> | |||
| </div> | |||
| <?php if (FreshRSS_Context::$user_conf->show_favicons): ?><img class="favicon" src="<?= $feed->favicon() ?>" alt="✇" /><?php endif; ?> | |||
| <?php if (FreshRSS_Context::$user_conf->show_favicons): ?><img class="favicon" src="<?= $feed->favicon() ?>" alt="✇" loading="lazy" /><?php endif; ?> | |||
There was a problem hiding this comment.
Does it actually make a difference here given how it doesn't depend on display:none? I ask mainly because the articles themselves are already lazy loaded.
There was a problem hiding this comment.
In the mobile view, this part is now shown, for instance. And in the main view, when categories are collapsed, it might work as well (not tested yet)
Alkarex
approved these changes
May 10, 2020
|
Merci @upskaling |
upskaling
added a commit
to upskaling/FreshRSS
that referenced
this pull request
May 11, 2020
upskaling
added a commit
to upskaling/FreshRSS
that referenced
this pull request
May 11, 2020
Alkarex
pushed a commit
that referenced
this pull request
May 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chargement des favicon en différé