install routine: template to html5 #3713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
approved these changes
Jul 23, 2021
| <li class="item<?= STEP == 3 ? ' active' : '' ?>"><a href="?step=3"><?= _t('install.conf') ?></a></li> | ||
| <li class="item<?= STEP == 4 ? ' active' : '' ?>"><a href="?step=4"><?= _t('install.this_is_the_end') ?></a></li> | ||
| </ul> | ||
| </nav> | ||
|
|
||
| <div class="post"> |
There was a problem hiding this comment.
Is #global the main or this one?
There was a problem hiding this comment.
both would be fine.
#global would be better in sync to https://github.com/FreshRSS/FreshRSS/blob/edge/app/views/index/global.phtml (where the class global is changed to <main>)
There was a problem hiding this comment.
Alright, let's stick to #global then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3643 (forget to check the install routine within #3651)
Changes proposed in this pull request:
<main>,<nav>,<headerHow to test the feature manually:
Pull request checklist:
Additional information can be found in the documentation.