Use typographic quotes #4133
Merged
Use typographic quotes #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
Jan 8, 2022
Frenzie
reviewed
Jan 8, 2022
Frenzie
reviewed
Jan 8, 2022
Frenzie
reviewed
Jan 8, 2022
|
Done! No more feedback @Frenzie ? :-) |
Frenzie
reviewed
Jan 8, 2022
Left for a future dedicated discussion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this minor PR, I applied a few search & replace to use typographic quotes
’instead of'. In addition to being more proper and nicer, it also removes the need of a few backslashes\Furthermore, I manually did a few replacements
"by their corresponding typographic ones such as“ ”and« »but most is left for future work.Finally, I manually did a few replacements of
...by…