Remove unused code and comments from pre-types implementation #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up massive amounts of commented-out and unused code from before the typed system was implemented. Removed:
Hundreds of lines of commented-out code in VMCore.cpp Parse() method
All old instruction implementations using uint32_t* params signature
Unused syscalls and old Value system methods
Commented-out template code in BaseValue.h/cpp
Unused stack/variable management methods
Dead code in FBinary.cpp and InstructionSet.h
Unused includes and excessive blank lines
Files Changed:
FriedVM/VMCore.cpp - Major cleanup, removed ~1000+ lines
FriedVM/VMCore.h - Removed unused method declarations
FriedVM/Types/BaseValue.h - Removed commented template code
FriedVM/Types/BaseValue.cpp - Removed commented implementations
FriedVM/FBinary.cpp - Removed commented methods
FriedVM/InstructionSet.h - Removed commented definitions
Impact:
Significantly improved code readability
Reduced maintenance burden
Cleaner architecture focused on current typed system
No functional changes to runtime behavior