Test SDK loading before widget tag #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rokostik
commented
Jan 15, 2025
| ta.focus(); | ||
|
|
||
| t.assert.equal(w.getState(), "unactivated") |
There was a problem hiding this comment.
This was flaky for me and the state was in init a lot of times.
greenberga
reviewed
Jan 15, 2025
| // Already unactivated (init done) | ||
| } else { | ||
| const unactivatedPromise = t.assert.widgetInits(w); | ||
| await unactivatedPromise; |
There was a problem hiding this comment.
Nitty, but why not just await t.assert.widgetInits(w)?
There was a problem hiding this comment.
Ah, you're right, it isn't needed. I was basing the test on start_mode_auto that had it. I've the promise var on both in 16c4d28
greenberga
approved these changes
Jan 15, 2025
|
I'm going to hold off merging this PR until https://github.com/FriendlyCaptcha/friendly-captcha/issues/1889 is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a test for the situation where the SDK loads before a widget tag that contains the EU API endpoint attribute.
It also removes the EU API endpoint meta attribute since all the tests that need it define it in the widget tag.