Fix handling of apiEndpoint in constructor
#34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to keep track of whether an `apiEndpoint` was passed to the `FriendlyCaptchaSDK` constructor. And then check it when creating widgets. The order of priority for determining a widget's `apiEndpoint` should be 1. `CreateWidgetOptions` 2. `data-api-endpoint` 3. `FriendlyCaptchaSDKOptions` 4. `getSDKAPIEndpoint()`
gzuidhof
approved these changes
Jan 31, 2025
| // Returns true if a widget iframe (corresponding to the passed widget id) | ||
| // exists and has the given endpoint in its `src` attribute. | ||
| function widgetIFrameHasCorrectSrc(id: string, endpoint: string) { | ||
| const iframe = document.querySelector(`[data--frc-frame-id="${id}"]`); |
There was a problem hiding this comment.
Suggested change
| const iframe = document.querySelector(`[data--frc-frame-id="${id}"]`); | |
| const iframe = document.querySelector(`[data--frc-frame-id="${id}"]`); |
Surprised there's the double dash 🤔 - I suppose it works :)
There was a problem hiding this comment.
Yeah, I pulled that from the Elements panel of the Developer Tools 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to keep track of whether an
apiEndpointwas passed to theFriendlyCaptchaSDKconstructor. And then check it when creating widgets. The order of priority for determining a widget'sapiEndpointshould beCreateWidgetOptionsdata-api-endpointFriendlyCaptchaSDKOptionsgetSDKAPIEndpoint()