minor #140 Upgrade to Psalm v4.1.1 (pamil)

This PR was merged into the 2.2-dev branch. Discussion ---------- Commits ------- fbcf9d0 Upgrade to Psalm v4.1.1
FriendsOfBehat · Nov 5, 2020 · 3ded19c · 3ded19c
2 parents 4c50529 + fbcf9d0
commit 3ded19c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/composer.json b/composer.json
@@ -24,7 +24,7 @@
         "friends-of-behat/mink-extension": "^2.2",
         "friends-of-behat/page-object-extension": "^0.3.1",
         "friends-of-behat/service-container-extension": "^1.0",
-        "vimeo/psalm": "3.10.1",
+        "vimeo/psalm": "4.1.1",
         "sylius-labs/coding-standard": "^3.0",
         "symfony/browser-kit": "^4.4|^5.0",
         "symfony/framework-bundle": "^4.4|^5.0",

diff --git a/src/Context/Environment/Handler/ContextServiceEnvironmentHandler.php b/src/Context/Environment/Handler/ContextServiceEnvironmentHandler.php
@@ -87,29 +87,29 @@ public function supportsEnvironmentAndSubject(Environment $environment, $testSub
     /**
      * @throws EnvironmentIsolationException
      */
-    public function isolateEnvironment(Environment $uninitializedEnvironment, $testSubject = null): Environment
+    public function isolateEnvironment(Environment $environment, $testSubject = null): Environment
     {
-        $this->assertEnvironmentCanBeIsolated($uninitializedEnvironment, $testSubject);
+        $this->assertEnvironmentCanBeIsolated($environment, $testSubject);
 
-        $environment = new InitializedSymfonyExtensionEnvironment($uninitializedEnvironment->getSuite());
+        $isolatedEnvironment = new InitializedSymfonyExtensionEnvironment($environment->getSuite());
 
-        foreach ($uninitializedEnvironment->getServices() as $serviceId) {
+        foreach ($environment->getServices() as $serviceId) {
             /** @var Context $context */
             $context = $this->getContainer()->get($serviceId);
 
             $this->initializeContext($context);
 
-            $environment->registerContext($context);
+            $isolatedEnvironment->registerContext($context);
         }
 
         /** @var InitializedContextEnvironment $delegatedEnvironment */
-        $delegatedEnvironment = $this->decoratedEnvironmentHandler->isolateEnvironment($uninitializedEnvironment->getDelegatedEnvironment());
+        $delegatedEnvironment = $this->decoratedEnvironmentHandler->isolateEnvironment($environment->getDelegatedEnvironment());
 
         foreach ($delegatedEnvironment->getContexts() as $context) {
-            $environment->registerContext($context);
+            $isolatedEnvironment->registerContext($context);
         }
 
-        return $environment;
+        return $isolatedEnvironment;
     }
 
     private function initializeContext(Context $context): void