Fix for #88

[DonCallisto]

#88 (comment)

[DonCallisto]

@pamil forgot to add bind section to first test. This way it was failing due to misconfiguration (no service for AbstractBrowser). Just let me try to fix and see if still fails

[DonCallisto]

@pamil umh, I'm a little bit confused. That's the situation where it should not pass. Am I missing something?

[cv65kr]

Hey

To generate failed test you must provide some changes.

I changed temporary in tests/Behat/Context/TestContext.php line 120
from

'test' => $this->getEnvironment() === 'test',

to

'test' => false

Because this problem exists when enviroment is set to another value than test. Thats should be do in separate step or just provide as parameter in step.

[cv65kr]

Given a working Symfony application with SymfonyExtension configured
And a feature file containing

Because you must use CompilerPass from src/Bundle/DependencyInjection/FriendsOfBehatSymfonyExtensionExtension:process.

[DonCallisto]

@cv65kr why environment should be different than test?
This extension is used specifically in test environment, so why should the test case take into account a different env?

[cv65kr]

client.test is always available when environment is set to test (https://symfony.com/doc/current/reference/configuration/framework.html#test).

In previous version of this extension you have a possibility to run Behat tests with different environment then test.

[DonCallisto]

Umh, but when I run tests in a Symfony app (and so #88 issue arise), I suppose that environment value was/is test.
Am I missing something?

[cv65kr]

Little weird, first of all try to set up test to true in your configuration then we will look if problem still exist.

[DonCallisto]

@cv65kr check out now. env is setted to test and test is green.

[cv65kr]

I mean

framework:
    test: true

in config/framework.yml because that's enable test.client service (https://github.com/symfony/symfony/blob/3e57f1f49f993b275fc014e029fc542ead2c15fb/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php#L261)

Let's try. If you change this value to false then test should failed. Maybe when APP_ENV is set to test this configuration is set up automatically.

Also try debug FrameworkExtension to make sure if test.client is not removed.

[DonCallisto]

@cv65kr this should be the same. Am I wrong?
If I change the value to dev, the test fails.

[cv65kr]

I lost myself 😄 same with?

[DonCallisto]

What I've done is (practically) the same of

framework:
    test: true

Isn't it?

[cv65kr]

Right, that should be equals.

[Yozhef]

@DonCallisto can you please update your branch in master - we need run GitHub Actions

[DonCallisto]

@Yozhef done

[Yozhef]

@cv65kr tell me do you have any other comments?