Import step fix #180
Merged
Import step fix #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…otherwise the color could be wrong by one. For example in file Dies_15.stp, there is a red value of 0.313725490196078, that became 79 (79.999999999999886), instead of 80.
… the case of 3d nurbs; nubs2d and nurbs2d not null should be tested (like in PointDirAtParam). It could append after the call of TrimParam that calls getPlane to make the new spline that will cause the creation of a plane (maybe also arbitrary).
In my case it was a file with only shell containing a single face, and some of them are not imported for other problems.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.